-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better-Lyrics Styling for Synced-Lyrics #2554
base: master
Are you sure you want to change the base?
Conversation
Love this! You have my full support for the port. If you want - happy to create a channel for this port in our discord so we can keep things in sync :)) |
I love the original synced-lyrics line effect. You should probaly make enabling Better-lyrics style optional. Better-lyrics line effect is too big to me. |
Ideally this should be merged after #2383 |
@kimjammer no need to "port" romanization or translation features from someone else's code they are on my TODO list for after I am done with my current PR |
I should have clarified: the "port" is referring to the CSS, I don't really care where the romanization or the translations come from. For reference, the better lyrics CSS for the romanization & translation |
Alrighty! PR is ready for review - (none of the repo contributors have even said if they think this pr is a good idea yet lol)
I took a random guess at how i18n was supposed to be done, if there's more lmk. |
#2554 (comment) |
I think this will get out of hand if everyone who has an opinion makes a request. Disclaimer: I am not a maintainer, so I don't have the final say, this is merely a suggestion to improve the user experience overall and not in just some areas. I invite anyone that wants to make further changes to converse in the linked issue. Adding a settings toggle to switch between the old and new CSS in order to make everyone happy is a spaghetti solution. I hope I didn't come off as being dismissive or rude, I just really think we should not rush things. |
Maintainers, lmk if you have opinions or changes to request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this PR after #2383 is merged.
This PR reimplements the CSS styles and animations for synced-lyrics so that it is more like the lyrics view for Spotify or the YT music mobile apps.
Yesterday, I found boidushya/better-lyrics and while it's great, it's a web browser extension so you can't install it into this app. So, I spent an afternoon porting the CSS over from that into this pr.
This PR is a draft because:
(Assuming boidushya has ping on mention turned on: Would you be okay with this few dozen line CSS port? Would you mind if I eventually (not this pr) ported the romanization and translation features as well?)
What do you think? I'm open for discussion.
Screen.Recording.2024-10-26.194514.mp4